Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #333

Open
code423n4 opened this issue Aug 6, 2022 · 0 comments
Open

QA Report #333

code423n4 opened this issue Aug 6, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid

Comments

@code423n4
Copy link
Contributor

1- ’0’ address Check

Context:

HomeFi.sol#L98

**Description:**�
Also check the length of the address to protect the code from short address problem just in case.This is best practice

Proof of Concept:
https://twitter.com/samczsun/status/1554252024723546112?s=20&t=mjJTwhMQz6LS_azlM3TTWQ

Recommendation:
like this ;
require(_forwarder != address(0x0));

2- Not correct Title

Context:

ProjectFactory.sol#L73-L75

**Description:**�
createProject function is external, but title was written to ’EXTERNAL VIEWS’ in line74

Recommendation:
Change to this title
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Aug 6, 2022
code423n4 added a commit that referenced this issue Aug 6, 2022
@code423n4
0xSmartContract issue #333
28bcb70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @jack-the-pug