QA Report #36
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
valid
Low Risk
Tasks assigned with a cost of 1 USDC will always revert
https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/Project.sol#L903-L911
Since USDC has 6 decimals, 1 cent is equivalent to 0.01 * 1e6 = 1e4, which makes the calculation be equal to zero.
Missing zero address check
https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/HomeFi.sol#L200
Non-critical
Non-view function marked under external view comment
https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/ProjectFactory.sol#L78
Typos
https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/Project.sol#L514
https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/Project.sol#L520
Unnecessary
uint256()
castinghttps://github.com/code-423n4/2022-08-rigor/blob/main/contracts/Project.sol#L200
Function returns a value which is never assigned
https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/HomeFi.sol#L225
Community number zero is never assigned
This happens because the community count is increased before
_communities[communityCount]
is called.https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/Community.sol#L140
The text was updated successfully, but these errors were encountered: