Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #36

Open
code423n4 opened this issue Aug 3, 2022 · 1 comment
Open

QA Report #36

code423n4 opened this issue Aug 3, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid

Comments

@code423n4
Copy link
Contributor

Low Risk

Tasks assigned with a cost of 1 USDC will always revert

https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/Project.sol#L903-L911

Since USDC has 6 decimals, 1 cent is equivalent to 0.01 * 1e6 = 1e4, which makes the calculation be equal to zero.

Missing zero address check

https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/HomeFi.sol#L200

Non-critical

Non-view function marked under external view comment

https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/ProjectFactory.sol#L78

Typos

https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/Project.sol#L514
https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/Project.sol#L520

Unnecessary uint256() casting

https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/Project.sol#L200

Function returns a value which is never assigned

https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/HomeFi.sol#L225

Community number zero is never assigned

This happens because the community count is increased before _communities[communityCount] is called.

https://github.com/code-423n4/2022-08-rigor/blob/main/contracts/Community.sol#L140

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Aug 3, 2022
code423n4 added a commit that referenced this issue Aug 3, 2022
@zgorizzo69
Copy link
Collaborator

thanks for your work good call for the check precision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid
Projects
None yet
Development

No branches or pull requests

3 participants