We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calldata access has the same cost as memory access already, so caching calldata -> memory is a waste of gas.
https://github.com/code-423n4/2022-09-frax/blob/main/src/OperatorRegistry.sol#L62
Instead of require(minters[minter_address] == true, "Address nonexistant"); simply write require(minters[minter_address], "Address nonexistant");
require(minters[minter_address] == true, "Address nonexistant");
require(minters[minter_address], "Address nonexistant");
https://github.com/code-423n4/2022-09-frax/blob/main/src/ERC20/ERC20PermitPermissionedMint.sol#L78 https://github.com/code-423n4/2022-09-frax/blob/main/src/ERC20/ERC20PermitPermissionedMint.sol#L46
The text was updated successfully, but these errors were encountered:
rokinot data for issue #351
4ed32d2
rokinot issue #351
f2a3cfa
No branches or pull requests
Calldata length should not be cached
Calldata access has the same cost as memory access already, so caching calldata -> memory is a waste of gas.
https://github.com/code-423n4/2022-09-frax/blob/main/src/OperatorRegistry.sol#L62
No need to compare boolean variables as true
Instead of
require(minters[minter_address] == true, "Address nonexistant");simply writerequire(minters[minter_address], "Address nonexistant");https://github.com/code-423n4/2022-09-frax/blob/main/src/ERC20/ERC20PermitPermissionedMint.sol#L78
https://github.com/code-423n4/2022-09-frax/blob/main/src/ERC20/ERC20PermitPermissionedMint.sol#L46
The text was updated successfully, but these errors were encountered: