Skip to content

Commit

Permalink
ahayashi data for issue #238
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Dec 18, 2022
1 parent eaf24d9 commit 3ec1180
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions data/ahayashi-Q.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
## Title
[NC-AH-01] Use `byte32(0)` instead of `byte23(0)`

## Summary
`merkleRoot` is defined as `bytes32` type but it is compared to `bytes23(0)`.

This is a different issue from the one noted in [GAS-2](https://gist.github.com/Picodes/42f9144fd8cba738f3a7098411737760#GAS-2) though it could be resolved by reflecting the GAS-2 remarks, but may not do so for readability.

## Lines
```solidity
File: src/Pair.sol
25: bytes32 public immutable merkleRoot;
465: if (merkleRoot == bytes23(0)) return;
```

0 comments on commit 3ec1180

Please sign in to comment.