ERC1155Quest.withdrawRemainingTokens allow owner to withdraw token that should be reserved for claiming

[code423n4]

Lines of code

https://github.com/rabbitholegg/quest-protocol/blob/8c4c1f71221570b14a0479c216583342bd652d8d/contracts/Erc1155Quest.sol#L54

Vulnerability details

Impact

Erc1155Quest allow owner to withdraw all balance from the Quest contract anytime, unlike in Erc20Quest where the owner's ability to withdraw token is significantly restricted (owner can only withdraw protocol fee, and remaining token less claimable portion). Although this is an privileged function, the way that its implementation deviated from the other Quest contract Erc20Quest made this Med RIsk since one may expect proper restriction in terms of admin withdrawing reward token when using ERC1155 token as ERC20 token.

https://github.com/rabbitholegg/quest-protocol/blob/8c4c1f71221570b14a0479c216583342bd652d8d/contracts/Erc1155Quest.sol#L54

    function withdrawRemainingTokens(address to_) public override onlyOwner {
        super.withdrawRemainingTokens(to_);
        IERC1155(rewardToken).safeTransferFrom(
            address(this),
            to_,
            rewardAmountInWeiOrTokenId,
            IERC1155(rewardToken).balanceOf(address(this), rewardAmountInWeiOrTokenId),
            '0x00'
        );
    }

Recommended Mitigation Steps

Implement checks as appeared in Erc20Quest

[c4-judge]

kirk-baird marked the issue as duplicate of #42

[c4-judge]

kirk-baird changed the severity to QA (Quality Assurance)

[c4-judge]

This previously downgraded issue has been upgraded by kirk-baird

[c4-judge]

kirk-baird marked the issue as satisfactory

[c4-judge]

kirk-baird changed the severity to 2 (Med Risk)