QA Report

[code423n4]

See the markdown file with the details of this report here.

[c4-pre-sort]

bytes032 marked the issue as sufficient quality report

[GalloDaSballo]

In the contract RdpxDecayingBonds.mint the require is redundant
L
The RdpxV2Core.approveContractToSpend() function doesn't perform as described in its NatSpec and function name
I
In the RdpxDecayingBonds:emergencyWithdraw function exist a wrong assumption
I
Remove/resolve the comments like the following
I
Potential accidental inclusion of ERC20Burnable in xETHDpxEthToken contract
R
Multiple uint mappings can be combined into a single mapping of a uint to a struct, where appropriate
-3, not applicable (indexes have diff meaning)
In the PerpetualAtlanticVaultLP.constructor missing check of input validation
-3, oos
Inconsistent Use of NatSpec
I
Inconsistent coding style
I
Empty blocks should be removed or emit something
I
Old version of OpenZeppelin Contracts used
R
In some important functions trough the scope should have better manage of events
-3, oos
In the UniV2LiquidityAmo.approveContractToSpend() function should emit some event
I
Crucial information is missing on important functions in all contracts
I
In some contracts, we find inconsistencies regarding uint256
R
We suggest to use named parameters for mapping type
I
We suggest using the OpenZeppelin SafeCast library
I
Use a single file for all system-wide constants
I
Use of deprecated function
L

2L 3R -9

[c4-judge]

GalloDaSballo marked the issue as grade-c

[catellaTech]

Hello, @GalloDaSballo! I hope you're doing well. I see that you gave me a grade C, but you didn't count me about the mediums you lowered to low:

#1873
#1886

Please, take into consideration that I not only performed the quality assurance but also conducted an analysis and submitted several findings of medium severity. I will be much more attentive next time; it is not my intention to undermine the effort I put into adding value.

[catellaTech]

this report #1493 mark as grade a have four -3 bc the bot 4R and 3L. please review my report again and add to the report the lows that a i mentioned above. 🤞

[GalloDaSballo]

4L 3R -9 with dups

[c4-judge]

GalloDaSballo marked the issue as grade-b