Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #425

Open
code423n4 opened this issue Aug 30, 2023 · 5 comments
Open

QA Report #425

code423n4 opened this issue Aug 30, 2023 · 5 comments
Labels
bug Something isn't working edited-by-warden grade-a Q-43 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Aug 30, 2023
code423n4 added a commit that referenced this issue Aug 30, 2023
@code423n4
T1MOH issue #425
3b2171a
code423n4 added a commit that referenced this issue Aug 30, 2023
@code423n4
T1MOH data for issue #425
09786ac
code423n4 added a commit that referenced this issue Aug 30, 2023
@code423n4
Report for issue #425 updated by T1MOH
885d2d2
code423n4 added a commit that referenced this issue Aug 30, 2023
@code423n4
Report for issue #425 updated by T1MOH
ac22659
code423n4 added a commit that referenced this issue Aug 30, 2023
@code423n4
Report for issue #425 updated by T1MOH
e51660d
code423n4 added a commit that referenced this issue Aug 30, 2023
@code423n4
Report for issue #425 updated by T1MOH
0b31a2c
code423n4 added a commit that referenced this issue Sep 2, 2023
@code423n4
Report for issue #425 updated by T1MOH
738fa7e
code423n4 added a commit that referenced this issue Sep 2, 2023
@code423n4
Report for issue #425 updated by T1MOH
af793cf
code423n4 added a commit that referenced this issue Sep 2, 2023
@code423n4
Report for issue #425 updated by T1MOH
445b556
@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Sep 10, 2023
@c4-pre-sort
Copy link

bytes032 marked the issue as sufficient quality report

@GalloDaSballo
Copy link

GalloDaSballo commented Oct 10, 2023 •
edited
Loading

1. Memory will be corrupted if add reserve with the same symbol

L

2. Allow to set 0 approval

L

3. RdpxDecayingBonds.sol can't send native value

L

4. RdpxV2Core.sol can issue bonds with immediate maturity

L

5. Confusing comment on upperDepeg()

L

6. UniLiquidityAmo contracts doesn't synchronize reserve balances of RdpxV2Core in some cases

M

@T1MOH593
Copy link

T1MOH593 commented Oct 23, 2023 •
edited
Loading

I am a little bit confused because in #770 you set grade-b. However it can be grade-a if take into consideration downgraded issues #422, #648, #770

@c4-judge c4-judge mentioned this issue Oct 24, 2023
Closed
@GalloDaSballo
Copy link

5L

3L from dups

8L

@c4-judge
Copy link
Contributor

GalloDaSballo marked the issue as grade-a

@C4-Staff C4-Staff added the Q-43 label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working edited-by-warden grade-a Q-43 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@GalloDaSballo @T1MOH593 @code423n4 @captainmangoC4 @c4-judge @c4-pre-sort @C4-Staff