Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #839

Closed
code423n4 opened this issue Sep 2, 2023 · 5 comments
Closed

QA Report #839

code423n4 opened this issue Sep 2, 2023 · 5 comments
Labels
bug Something isn't working grade-c QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Sep 2, 2023
code423n4 added a commit that referenced this issue Sep 2, 2023
@code423n4
rokinot issue #839
039d5e8
code423n4 added a commit that referenced this issue Sep 2, 2023
@code423n4
rokinot data for issue #839
d634a2a
@c4-pre-sort
Copy link

bytes032 marked the issue as sufficient quality report

@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Sep 10, 2023
@GalloDaSballo
Copy link

GalloDaSballo commented Oct 10, 2023 •
edited
Loading

UniV2LiquidityAMO: Balance function may return wrong value

L,

UniV2LiquidityAMO: Slippage tolerance is never enforced

R

UniV3LiquidityAMO: Contract will stop working in 2036

L

UniV3LiquidityAMO: recoverERC721() does not, in fact, recovers them

H

RdpxV2Core: Admin can break bonding by setting fee and/or burn percentage to > 100%

I

PerpetualAtlanticVaultLP: Redemptions are temporarily locked if all collateral is consumed

L

RdpxV2Core: Bond maturity is initially set to zero

L

Misleading comment in RdpxV2Core

L

Two functions are not using proper camelCase

R

Redundant check in RdpxV2Core

R

Maximum bondDiscount is 50% rather than 100% in RdpxV2Core

L

@liveactionllama liveactionllama added grade-c unsatisfactory does not satisfy C4 submission criteria; not eligible for awards labels Oct 21, 2023
@liveactionllama
Copy link

Per discussion with judge, adding grade labels on their behalf.

@rokinot
Copy link

rokinot commented Oct 21, 2023

Hi, could the judge give a more detailed explanation as to why this grade was given? Especially given the fact that there are some H/M dupes, it seems like they haven't been judged yet. According to the spreadsheet, the relative score was zero, and I cannot see why, other than the review being incomplete as of now.

@c4-judge c4-judge mentioned this issue Oct 24, 2023
Closed
@GalloDaSballo
Copy link

6L 3R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grade-c QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@GalloDaSballo @rokinot @code423n4 @liveactionllama @c4-pre-sort