Skip to content

Commit

Permalink
Report for issue #127 updated by Tadev
Browse files Browse the repository at this point in the history
  • Loading branch information
c4-bot-1 committed Nov 3, 2023
1 parent 7557e7d commit 040864f
Showing 1 changed file with 23 additions and 1 deletion.
24 changes: 23 additions & 1 deletion data/Tadev-G.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,29 @@ https://github.com/code-423n4/2023-10-nextgen/blob/8b518196629faa37eae39736837b2
This string variable `tokdata` should also be removed, and `_tokendata` should be used wherever `tokdata` is currently used.


## [G‑04]
## [G‑04] 2 variables are created and assigned to the same value in `burnToMint()` function in NextGenMinterContract. One of them should be removed.

https://github.com/code-423n4/2023-10-nextgen/blob/8b518196629faa37eae39736837b24926fd3c07c/hardhat/smart-contracts/MinterContract.sol#L264

https://github.com/code-423n4/2023-10-nextgen/blob/8b518196629faa37eae39736837b24926fd3c07c/hardhat/smart-contracts/MinterContract.sol#L267

Both `collectionTokenMintIndex` and `mintIndex` variables are assigned to `gencore.viewTokensIndexMin(_mintCollectionID) + gencore.viewCirSupply(_mintCollectionID)`.

This is redondant. Hence, `mintIndex` should me removed, as there is an important check just after `collectionTokenMintIndex` declaration and assignment. Also, `mintIndex` should be replace where it used :

```
gencore.burnToMint(mintIndex, _burnCollectionID, _tokenId, _mintCollectionID, _saltfun_o, burner);
```
should be:
```
gencore.burnToMint(collectionTokenMintIndex, _burnCollectionID, _tokenId, _mintCollectionID, _saltfun_o, burner);
```


## [G‑05]






Expand Down

0 comments on commit 040864f

Please sign in to comment.