Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #191

Open
c4-submissions opened this issue Nov 3, 2023 · 7 comments
Open

Gas Optimizations #191

c4-submissions opened this issue Nov 3, 2023 · 7 comments
Labels
bug Something isn't working edited-by-warden G (Gas Optimization) G-16 grade-a selected for report This submission will be included/highlighted in the audit report sufficient quality report This report is of sufficient quality

Comments

@c4-submissions
Copy link
Contributor

See the markdown file with the details of this report here.
@c4-submissions c4-submissions added bug Something isn't working G (Gas Optimization) labels Nov 3, 2023
c4-submissions added a commit that referenced this issue Nov 3, 2023
@c4-submissions
rahul issue #191
efbbaf2
c4-submissions added a commit that referenced this issue Nov 3, 2023
@c4-submissions
rahul data for issue #191
1bce5af
c4-bot-10 added a commit that referenced this issue Nov 4, 2023
@c4-bot-10
Report for issue #191 updated by rahul
6231a62
c4-bot-4 added a commit that referenced this issue Nov 13, 2023
@c4-bot-4
Report for issue #191 updated by rahul
f76cd26
@141345
Copy link

141345 commented Nov 26, 2023

191 rahul
l r nc
3 1 3

G 1 n
G 2 n
G 3 l
G 4 n
G 5 l
G 6 l
G 7 r

@c4-pre-sort
Copy link

141345 marked the issue as sufficient quality report

@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Nov 26, 2023
@alex-ppg
Copy link

alex-ppg commented Dec 2, 2023 •
edited
Loading

G-4 might be invalid due to set final supply which can in certain circumstances result in 0 for a collection that "exists". Otherwise solid contender for best report!

@c4-judge
Copy link

c4-judge commented Dec 2, 2023

alex-ppg marked the issue as grade-a

@c4-judge
Copy link

c4-judge commented Dec 9, 2023

alex-ppg marked the issue as selected for report

@c4-judge c4-judge added the selected for report This submission will be included/highlighted in the audit report label Dec 9, 2023
@c3phas
Copy link

c3phas commented Dec 10, 2023

Now, this is an interesting report. Nice work

@C4-Staff C4-Staff added the G-16 label Dec 14, 2023
@thebrittfactor
Copy link
Contributor

Just a note that C4 is excluding the invalid entries from the official report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working edited-by-warden G (Gas Optimization) G-16 grade-a selected for report This submission will be included/highlighted in the audit report sufficient quality report This report is of sufficient quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@c3phas @alex-ppg @141345 @c4-judge @c4-pre-sort @C4-Staff @thebrittfactor @c4-submissions @code4rena-admin