Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis #2028

Closed
c4-submissions opened this issue Nov 13, 2023 · 5 comments
Closed

Analysis #2028

c4-submissions opened this issue Nov 13, 2023 · 5 comments
Labels
analysis-advanced grade-c insufficient quality report This report is not of sufficient quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@c4-submissions
Copy link
Contributor

See the markdown file with the details of this report here.

c4-submissions added a commit that referenced this issue Nov 13, 2023
c4-submissions added a commit that referenced this issue Nov 13, 2023
@c4-pre-sort c4-pre-sort added the insufficient quality report This report is not of sufficient quality label Nov 27, 2023
@c4-pre-sort
Copy link

141345 marked the issue as insufficient quality report

@alex-ppg
Copy link

alex-ppg commented Dec 7, 2023

The Analysis Report has been graded as C given that it falls in one of the below categories:

  • Rudimentary listing of contracts and a textual description of them
  • Rehash of data present in the documentation of the project as well as its website, and any other such resource
  • Incorrect information or information that is very generic/vague and potentially inapplicable to the NextGen project
  • Minimal data presented, or reiterating data of the Warden's submissions
  • Findings better suited as part of a QA submission

@c4-judge c4-judge closed this as completed Dec 7, 2023
@c4-judge
Copy link

c4-judge commented Dec 7, 2023

alex-ppg marked the issue as grade-c

@c4-judge c4-judge added grade-c unsatisfactory does not satisfy C4 submission criteria; not eligible for awards labels Dec 7, 2023
@Nabeel-javaid
Copy link

hey, kindly have another look at this analysis report as i've read the comments on the report and I would say that warden have listed all the information that is necessary for the analysis report and have also tried to list some extra info. IDK what do you mean by "vague" cause all the information is strictly in the domain of this project

@alex-ppg
Copy link

alex-ppg commented Dec 9, 2023

Hey @Nabeel-javaid, thanks for requesting additional background for this ruling!

I started by compiling a chapter-by-chapter grade of this submission, however, all chapters appear to be insufficient to acquire a grade. All chapters contain boilerplate text / generic that is not strictly applicable to NextGen and can be copy-pasted to apply to any project.

For example, the only NextGen-specific information in Codebase Quality Analysis is the two function names mentioned which do not indicate which contract they stem from.

The Suggestion for Decentralized Governance chapter was provided without any acknowledgment of the current ownership structure of NextGen nor mention of their use of a Gnosis Safe which the Sponsor had provided upon request to multiple other wardens.

The Mechanism Review chapter which is arguably the only NextGen-specific content in the Analysis falls into the Rehash of data present in the documentation of the project as well as its website, and any other such resource category. It offers no newfound insights, and also does not mention all ways an NFT can be minted/burned, such as burnOrSwapExternalToMint.

Based on the above, I maintain the C grade I have assigned for this Analysis. For more information on how Analysis reports should look, kindly consult the grade-A submissions as follows: #2005 #1888 #1841 #1563 #1472 #926 #772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis-advanced grade-c insufficient quality report This report is not of sufficient quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Development

No branches or pull requests

5 participants