Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #23

Closed
c4-submissions opened this issue Oct 31, 2023 · 4 comments
Closed

QA Report #23

c4-submissions opened this issue Oct 31, 2023 · 4 comments
Labels
bug Something isn't working grade-c QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@c4-submissions
Copy link
Contributor

See the markdown file with the details of this report here.

@c4-submissions c4-submissions added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Oct 31, 2023
c4-submissions added a commit that referenced this issue Oct 31, 2023
@141345
Copy link

141345 commented Nov 25, 2023

23 fatherOfBlocks
l r nc
0 0 3

L 1 n
L 2 i
L 3 i
L 4 n
L 5 i
L 6 n
L 7 i
L 8 i
L 9 i

@c4-pre-sort
Copy link

141345 marked the issue as sufficient quality report

@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Nov 25, 2023
@alex-ppg
Copy link

alex-ppg commented Dec 5, 2023

smart-contracts/NextGenCore.sol

  • Generic recommendation

smart-contracts/MinterContract.sol

smart-contracts/RandomizerNXT.sol

  • Valid NC recommendation
  • Generic recommendation

smart-contracts/RandomizerVRF.sol

  • Unknown what Warden's intentions are here

smart-contracts/RandomizerRNG.sol

  • Unknown what Warden's intentions are here

smart-contracts/XRandoms.sol

  • Valid NC recommendation

@c4-judge
Copy link

c4-judge commented Dec 5, 2023

alex-ppg marked the issue as grade-c

@c4-judge c4-judge closed this as completed Dec 5, 2023
@c4-judge c4-judge added grade-c unsatisfactory does not satisfy C4 submission criteria; not eligible for awards labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grade-c QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Development

No branches or pull requests

5 participants