Missing time period check will result in revert during minting

[c4-submissions]

Lines of code

https://github.com/code-423n4/2023-10-nextgen/blob/main/smart-contracts/MinterContract.sol#L249

Vulnerability details

In the mint(), if the nft is to be minted at certain intervals then the time period interval is set at collectionPhases[col].timePeriod.
But there are possible chances that the mint function will revert because there is no check to ensure that the time period isn't set to 0 during sales option 3.

Proof of Concept

File: MinterContract.sol

     // control mechanism for sale option 3
        if (collectionPhases[col].salesOption == 3) {
            uint timeOfLastMint;
            if (lastMintDate[col] == 0) {
                // for public sale set the allowlist the same time as publicsale
                timeOfLastMint = collectionPhases[col].allowlistStartTime - collectionPhases[col].timePeriod;
            } else {
                timeOfLastMint =  lastMintDate[col];
            }
            // uint calculates if period has passed in order to allow minting
249:        uint tDiff = (block.timestamp - timeOfLastMint) / collectionPhases[col].timePeriod;  /// @note - will revert if timePeriod is 0
            // users are able to mint after a day passes
            require(tDiff>=1 && _numberOfTokens == 1, "1 mint/period");
            lastMintDate[col] = collectionPhases[col].allowlistStartTime + (collectionPhases[col].timePeriod * (gencore.viewCirSupply(col) - 1));
        }

Take the following scenario:

• Collection has a rate & time period greater than 0 for variable change in price per mint & time gap.
• collectionPhases[col].salesOption == 3 in this case.
• After sometime it is decided to do a 1 hour special mint where the price will be fixed & no time gap between mints.
• This means both rate & time period will be set to 0 which is done by the admin.
• Now the mint() is executed & it enters if (collectionPhases[col].salesOption == 3) block.
• tDiff = (block.timestamp - timeOfLastMint) / collectionPhases[col].timePeriod on line 249 will revert because of division by 0 because the time period has been set to 0.
• Thus during this time all the mints will revert.

Impact

Due to missing check, it is possible that minting will revert in case the time period is set to 0 during sales option 3.

Tools Used

Manual

Recommended Mitigation Steps

Add a check in the if block where the sales option is checked for time period to be greater than 0.

File: MinterContract.sol

- 240:   if (collectionPhases[col].salesOption == 3) {
+ 240:   if (collectionPhases[col].salesOption == 3 && collectionPhases[col].timePeriod > 0) {

Assessed type

Invalid Validation

[c4-pre-sort]

141345 marked the issue as duplicate of #478

[c4-pre-sort]

141345 marked the issue as not a duplicate

[c4-pre-sort]

141345 marked the issue as duplicate of #1278

[c4-pre-sort]

141345 marked the issue as duplicate of #962

[c4-pre-sort]

141345 marked the issue as not a duplicate

[c4-pre-sort]

141345 marked the issue as duplicate of #1278

[c4-judge]

alex-ppg marked the issue as duplicate of #1980

[c4-judge]

alex-ppg marked the issue as unsatisfactory:
Overinflated severity