There is no min/max(uint property) boundation of setCollectionCosts function properties.

[c4-submissions]

Lines of code

https://github.com/code-423n4/2023-10-nextgen/blob/main/smart-contracts/MinterContract.sol#L157

Vulnerability details

Proof of Concept

There is no min/max boundation of collectionMintCost, collectionEndMintCost,rate,timePeriod.
If collectionEndMintCost is greater than collectionMintCost(as there is no check) then , collectionPhases[_collectionId].collectionMintCost - collectionPhases[_collectionId].collectionEndMintCost(getPrice function line), this will underflow.

If rate is greater than collectionMintCost(as there is no check) then,
collectionPhases[_collectionId].collectionMintCost / collectionPhases[_collectionId].rate(getPrice function line) will return value 0. This will cause less minting cost.
price = collectionPhases[_collectionId].collectionMintCost - (tDiff * collectionPhases[_collectionId].rate); this will create underflow.

There is also no check of salesOption( it must be less than 4 and greater than 0) and delAddress(it must not be address(0) .

Impact

Precision loss and underflow(this will create DOS) may occur.

Tools Used

manual review

Recommended Mitigation Steps

Validate all those properties correctly.

Assessed type

Invalid Validation

[c4-pre-sort]

141345 marked the issue as duplicate of #478

[c4-judge]

alex-ppg marked the issue as not a duplicate

[c4-judge]

alex-ppg marked the issue as duplicate of #1831

[c4-judge]

alex-ppg marked the issue as unsatisfactory:
Overinflated severity