No valid check given

[c4-submissions]

Lines of code

https://github.com/code-423n4/2023-10-nextgen/blob/8b518196629faa37eae39736837b24926fd3c07c/smart-contracts/MinterContract.sol#L233

Vulnerability details

Impact

msg.value check will pass if _numOfTokens is 0 even ,but it will get stuck at looping causing an error

Proof of Concept

require(msg.value >= (getPrice(col) * _numberOfTokens), "Wrong ETH");
       for(uint256 i = 0; i < _numberOfTokens; i++) {
           uint256 mintIndex = gencore.viewTokensIndexMin(col) + gencore.viewCirSupply(col);
           gencore.mint(mintIndex, mintingAddress, _mintTo, tokData, _saltfun_o, col, phase);
       }

Tools Used

Manual Review

Recommended Mitigation Steps

Add a check before msg.value >= (getPrice(col) * _numberOfTokens)

Assessed type

Error

[c4-pre-sort]

141345 marked the issue as insufficient quality report

[c4-judge]

alex-ppg marked the issue as duplicate of #619

[c4-judge]

alex-ppg marked the issue as unsatisfactory:
Invalid