Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is many missing checks in nextgenadmin contract. #785

Closed
c4-submissions opened this issue Nov 10, 2023 · 4 comments
Closed

There is many missing checks in nextgenadmin contract. #785

c4-submissions opened this issue Nov 10, 2023 · 4 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate-644 insufficient quality report This report is not of sufficient quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@c4-submissions
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2023-10-nextgen/blob/main/smart-contracts/NextGenAdmins.sol#L15

Vulnerability details

Proof of Concept

In every function there is missing input validation i.e there is no check input data emptiness .
There is no check of address(0), 0 bytes,0 value of uint. There is also no check of existence of _collectionID(maybe collection id is not created still).

Tools Used

manual review

Recommended Mitigation Steps

Validate all function inputs correctly.

Assessed type

Invalid Validation
@c4-submissions c4-submissions added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Nov 10, 2023
c4-submissions added a commit that referenced this issue Nov 10, 2023
@c4-submissions
almurhasan issue #785
55970bd
@c4-pre-sort c4-pre-sort added the insufficient quality report This report is not of sufficient quality label Nov 20, 2023
@c4-pre-sort
Copy link

141345 marked the issue as insufficient quality report

@141345
Copy link

141345 commented Nov 20, 2023

bot race known issue L-02

@c4-judge
Copy link

c4-judge commented Dec 6, 2023

alex-ppg marked the issue as duplicate of #644

@c4-judge c4-judge closed this as completed Dec 6, 2023
@c4-judge
Copy link

c4-judge commented Dec 8, 2023

alex-ppg marked the issue as unsatisfactory:
Invalid

@c4-judge c4-judge added the unsatisfactory does not satisfy C4 submission criteria; not eligible for awards label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate-644 insufficient quality report This report is not of sufficient quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@141345 @c4-judge @c4-pre-sort @c4-submissions