Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #290

Open
c4-bot-1 opened this issue Apr 5, 2024 · 4 comments
Open

QA Report #290

c4-bot-1 opened this issue Apr 5, 2024 · 4 comments
Labels
bug Something isn't working grade-b Q-01 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons sufficient quality report This report is of sufficient quality

Comments

@c4-bot-1
Copy link
Contributor

c4-bot-1 commented Apr 5, 2024

See the markdown file with the details of this report here.
@c4-bot-1 c4-bot-1 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Apr 5, 2024
c4-bot-4 added a commit that referenced this issue Apr 5, 2024
@c4-bot-4
cheatc0d3 issue #290
f44095f
c4-bot-2 added a commit that referenced this issue Apr 5, 2024
@c4-bot-2
cheatc0d3 data for issue #290
44f03ca
@raymondfam
Copy link

L1, L2, L7, L8, L18, L24-29: Insufficient proof/elaboration
L3, L4, L6: Check the doc for the selected/intended uint type
L5: mul and div each has its proper scaling in place in the library
L12: function would revert anyway if ercAmount * price is less than the minimum dust
L13: Loop cap should be implemented in calling functions invoking bidMatchAlgo()
L14: Checks are well in place in LibOrders and LibOracles.

12 L/NC.

@c4-pre-sort
Copy link

raymondfam marked the issue as sufficient quality report

@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Apr 8, 2024
@c4-sponsor c4-sponsor added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Apr 9, 2024
@c4-sponsor
Copy link

ditto-eth (sponsor) acknowledged

@c4-judge
Copy link
Contributor

hansfriese marked the issue as grade-b

@C4-Staff C4-Staff added the Q-01 label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grade-b Q-01 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons sufficient quality report This report is of sufficient quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@raymondfam @c4-judge @c4-sponsor @c4-pre-sort @C4-Staff @c4-bot-1