ERC1155::supportsInterface should be virtual

[c4-bot-1]

Lines of code

https://github.com/code-423n4/2024-04-panoptic/blob/833312ebd600665b577fbd9c03ffa0daf250ed24/contracts/tokens/ERC1155Minimal.sol#L200-L204

Vulnerability details

Impact

ERC1155::supportsInterface should be virtual, otherwise it can't be override to add other interface-support.

Proof of Concept

In the function ERC1155::supportsInterface, there is no virtual for the function, so that it can not be override.

    function supportsInterface(bytes4 interfaceId) public pure returns (bool) {
        return
            interfaceId == 0x01ffc9a7 || // ERC165 Interface ID for ERC165
            interfaceId == 0xd9b67a26; // ERC165 Interface ID for ERC1155
    }

Since ERC1155 currently doesn't support interfaceId == 0x0e89341c(ERC165 Interface ID for ERC1155MetadataURI), the supportsInterface could not be changed to add more interfaces. This may cause future integration problems.

Tools Used

Manual

Recommended Mitigation Steps

Add virtual for function supportsInterface so that more interfaces could be added in the future for better implementation.

Assessed type

Other

[c4-judge]

Picodes changed the severity to QA (Quality Assurance)

[c4-judge]

Picodes marked the issue as grade-b