Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #71

Open
c4-bot-10 opened this issue Apr 12, 2024 · 4 comments
Open

QA Report #71

c4-bot-10 opened this issue Apr 12, 2024 · 4 comments
Labels
bug Something isn't working edited-by-warden grade-b Q-42 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@c4-bot-10
Copy link
Contributor

See the markdown file with the details of this report here.

@c4-bot-10 c4-bot-10 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Apr 12, 2024
c4-bot-7 added a commit that referenced this issue Apr 12, 2024
c4-bot-10 added a commit that referenced this issue Apr 12, 2024
@c4-judge
Copy link
Contributor

Picodes marked the issue as grade-c

@c4-judge c4-judge added grade-c unsatisfactory does not satisfy C4 submission criteria; not eligible for awards labels Apr 26, 2024
@c4-judge c4-judge reopened this Apr 26, 2024
@c4-judge c4-judge added grade-b and removed grade-c unsatisfactory does not satisfy C4 submission criteria; not eligible for awards labels Apr 26, 2024
@c4-judge
Copy link
Contributor

Picodes marked the issue as grade-b

@sathishpic22
Copy link

Hi @Picodes

Thanks for your judging and grades.

Upon reviewing the reports that received an A grade, I have observed that my submission exhibits a superior analysis. Notably, my report engages in a detailed examination of the protocol's codebase, whereas the A-graded reports lack such depth, focusing instead on superficial findings. Moreover, the findings in my report are not merely static detections generated by automated tools; they provide significant insights that are crucial for the sponsor, offering substantial value beyond the basic static analysis typically found in other submissions.

Given the comparative quality and depth of my analysis, I am confident that my report deserves a higher grade. I have ensured that my findings are not only more insightful but also more relevant to the sponsor's needs, avoiding common static findings that offer limited added value.

Thank you

@Picodes
Copy link

Picodes commented May 9, 2024

@sathishpic22 I hadn't dug in detail into the reported findings as the first ones are all close to being fully invalid:

  • L01 is invalid unless you explain how this value could potentially be below 100 as Uniswap minimal fee is 100
  • L02 makes no sense as this is called by the factory
  • L03 the tax is correctly implemented as a fee
  • L04 and L05 are exactly the same thing
  • L13 is fully invalid as well

So I went for grade-b. Please make sure to start your report with valuable low findings

@C4-Staff C4-Staff added the Q-42 label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working edited-by-warden grade-b Q-42 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

6 participants