Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist/blacklist for captions: lyric videos; karaokee; subtitled movies #1235

Open
lokzz opened this issue Feb 23, 2022 · 4 comments · Fixed by #2147
Open

Whitelist/blacklist for captions: lyric videos; karaokee; subtitled movies #1235

lokzz opened this issue Feb 23, 2022 · 4 comments · Fixed by #2147
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. data compare: https://github.com/LuanRT/YouTube.js & maybe github.com/MarcGuiselin/youtube-refined good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) ✰Unique unique ~ Worth extra work (not done anywhere in any way? out of the box?) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@lokzz
Copy link

lokzz commented Feb 23, 2022

  1. issue: the subtitles show up every video, even if it's a lyrics video.
  2. solution: whitelist/blacklist for captions
  3. other ways: scan title for "lyrics" or "lyric" or something of the sorts
@lokzz lokzz added Feature request Wish or idea help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Feb 23, 2022
@ImprovedTube ImprovedTube added ✰Unique unique ~ Worth extra work (not done anywhere in any way? out of the box?) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) and removed 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) labels Feb 24, 2022
@ImprovedTube
Copy link
Member

ImprovedTube commented Feb 24, 2022 •
edited
Loading

Yay! Wonder how in the world this has not been requested before.

  • karaokee, sing-along, lyrics video or just the word lyrics anywhere in title or tags if the category is music to be precise?.

  • A global / crowdsourced list of channels and videos?

  • more: movies/documentaries with subtitles/captions are very common in many languages/countries (instead of voice overs). so auto-captions could be disabled usually (except maybe when a users is always using auto translated caption to a third language, that is not already in the video)

@lokzz lokzz closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2022
@ImprovedTube
Copy link
Member

ImprovedTube commented Oct 8, 2022 •
edited
Loading

hi @lokzz ! news?

@ImprovedTube ImprovedTube reopened this Oct 8, 2022
@ImprovedTube ImprovedTube added the data compare: https://github.com/LuanRT/YouTube.js & maybe github.com/MarcGuiselin/youtube-refined label Sep 10, 2023
@ImprovedTube ImprovedTube added up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* labels Oct 19, 2023
@ImprovedTube
Copy link
Member

(compare: we have implemented music detection for the forced speed features by now. lyrics videos are mostly a subset of music)

@ImprovedTube ImprovedTube mentioned this issue Feb 19, 2024
Open
@ThomSipkens
Copy link
Contributor

ThomSipkens commented Feb 26, 2024 •
edited
Loading

Hey @ImprovedTube I'm new to open source, is this something I could start with and look into?

@ThomSipkens ThomSipkens mentioned this issue Apr 2, 2024
Merged
ImprovedTube added a commit that referenced this issue Apr 3, 2024
@ImprovedTube
Merge pull request #2147 from ThomSipkens/master
9240c71 
Add option to automatically disable captions in lyrics/karaoke videos #1235
@ImprovedTube ImprovedTube added Completion / Revision Rethink, complete, improve, tweak our feature or structure. and removed Feature request Wish or idea labels Apr 3, 2024
@ImprovedTube ImprovedTube reopened this Apr 3, 2024
@ImprovedTube ImprovedTube changed the title Whitelist/blacklist for captions Whitelist/blacklist for captions: lyric videos; karaokee; subtitled movies Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. data compare: https://github.com/LuanRT/YouTube.js & maybe github.com/MarcGuiselin/youtube-refined good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) ✰Unique unique ~ Worth extra work (not done anywhere in any way? out of the box?) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Priority B
Status: Done
Milestone
No milestone
3 participants
@ImprovedTube @lokzz @ThomSipkens