-
-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not playing video after youtube changes. more (confused?) uninstalls #1809
Comments
v4.339 and 4.401 working fine for me, video all playing for me. |
thank you! @dodieboy what about v4.400? |
V4.400 from the store is working fine for me. Did any user with the problem send their setting export file so we can test? |
Can the problem come from user having other ad block extension installed? Few week ago, I need to add this filter to my ad block extension
|
Hi, I also had the issue with videos not playing since the latest update. I found some odd things with addon/extension combinations, some helped, some made it worse. This is only for webpages with a video, browsing youtube didn't change. First off, I have 25 addons for firefox, a 7 of them for Youtube (although I normally dont have all enabled). I tested videos with a variety of combinations, including using only ImprovedYoutube. In particular I found strange interactions with ImprovedYoutube (IY), Ublock Origin (UO) and Enhancer for YouTube (EfY) (although I normally dont have Enhancer for YouTube enabled)
I have no idea why EfY is making a difference. I've had it installed but disabled for months. I only discovered the interaction when I was testing some combinations of addons. |
thanks @Desric88 interesting!
So our's alone makes the new YouTube not load?😲
|
*As soon as I posted this message, I realised that I didnt post the error logs of normal mode with IY disabled. But now Im getting the 'not loading bug' here too! I've since restarted my computer from my last post. Not only have I found new things, but some things are behaving differently.
While writing this I was tinkering more and now my homepage is acting weird, again. Once I had a few things load on a sidebar where they shouldnt have. Other times I got an old problem where the 'bar' with buttons like All, Music, New to You wont load, no matter what I do, even if I use my phone with the app or a browser. I'm certain that this account is bugged. Other things Ive tested:
Attached are 3 txt documents with error logs that I copy pasted from Firefox's console. Incognito with and without IY enabled and another in the normal mode with IY enabled (and IY is the only addon enabled) Incognito with IY.txt If anyone knows anything about the the 'bar' not loading, or wants pics of what it looks like, ask. It's really annoying how it randomly chooses what weeks it wants to show up. |
I just tried 4.40 and 4.41. No issues at all, even with UBlock Origin and friendly AdBlock activated 😓. I'm using Chromium 118. |
🥰 thank you! @Desric88 (shows nothing broken and you said it works in incognito. Can you send one where errors happen?)
this will really help so that we can compare the DOM with what we still get /the old one (and long term we should have people /a script doing this every single time youtube changes for anyone.) |
@ImprovedTube Good news, Im not getting the bugs any more, but bad news, Im not getting the bugs anymore so no additional reports unfortuantly. The thing that appears to have fixed it for me was clearing all data/cache/cookies from my whole browser instead of just things from youtube. Since then I cant reproduce any of the bugs. |
Don't have time to debug this issue specifically, but just wanted to mention that when working on a Youtube-related chrome extension, I noticed that the elements on the page were loaded very differently depending on if you started on the page, clicked there from another video, or clicked there from the homescreen; my interpretation at the time was that YouTube was "sending the full page contents with the initial HTML response" in some of those loading conditions (presumably when loading page anew or refreshing), whereas in others it would load it dynamically (presumably when autoplaying to or clicking the next video), with the varying routes resulting in different DOM structures. So basically: Any testing for this issue will need to cover each of the different "page loading conditions", since the DOM structure differs between them. (Oh also: Not only does the DOM structure differ, I remember that youtube liked to "keep around" the DOM for the video that was initially loaded, even after the user had moved onto the next video. So you can't just globally search for classname matches, for example, you have to make sure you only look in the DOM elements for the "current video". It was kind of a mess IIRC, and even my fixes for it were not 100% comprehensive.) |
@Venryx exactly! what code of yours are you referring to? thanks! |
Hello, I'd like to help but as a complete non-coder, I can only describe the issues I'm having. If any debug logs are needed, I can also provide that, if there are detailed instructions on how to obtain the logs. Primary issues I'm experiencing with playback on Youtube since a few days ago has persisted with the latest 4.401, even after complete restart of browser, along with clearing of all cache and cookies. I'm mostly experiencing it as an inability to use the defined play/pause keyboard shortcut, which I've set as the spacebar (I believe this is also default key for Youtube?) After opening a video's page, pressing spacebar doesn't start the video, I see the player's play button go from pause to play very rapidly (less than a second) then switch back, without the video playing at all. The only way to get the video to start playing is by clicking on the play button with my mouse. Then after it's started, pressing spacebar cannot stop the video either. Same symptom of seeing the player's play button status rapidly switching from play to puase and then play again. In step with the button status change, the video would incrementally pause briefly during that short time, but ultimately resumes playing. In this case I have to use the mouse again to click on the button in order to get the video to stop. Even then, actual video pausing is always a half second later, rather than immediately. I'm on Windows 7 SP1, browser Slimjet Version 38.0.9.0 (based on Chromium 109.0.5414.74) (Official Build) (32-bit). I only have a very few number of extensions installed and enabled, none of which have changed since before the problems began. Among these, uBlock Origin and Autoplay Stopper are the only ones also enabled on Youtube. I have Autoplay Stopper set to allow autoplay for http:// and https:// for www.youtube.com, and I've also tried disabling the extension outright. Nothing changes, so I don't think that's the issue. The same thing for uBlock Origin, I've tried disabling the extension, leaving nothing but ImproveYoutube running, and deleted cookies, reloaded the same video's page, the same symptoms with playback's shortcut not working persists. For testing I used the same video, and was not logged in to Youtube. Here are all the errors I copied from the browser console: Also wanted to say a big Thank You to all contributors for ImproveYoutube plugin. Considering how frequently Youtube updates their code and breaks things, the amount of work required in maintaining the extension and ensuring everything works properly must be staggering. Thank you for everything you do and for making ImproveYoutube free, allowing everyone to use it and enjoy Youtube with a little less annoyance. :) |
hi @PoorChameleon, removing since it didn't help the uninstalls count... - had to try since we still see many uninstalls (since YouTube's updates, October 18). |
I encountered this problem. Disabling the extension allowed videos to play. So I uninstalled and reinstalled. Videos still worked after the reinstall. Then I turned off "Video> Autoplay", and video playback stopped. Toggle this option back on, and videos play again. So it seems the bug is related to the autoplay feature. Hope this information is useful. My version is 4.404 on Brave Version 1.60.114 Chromium: 119.0.6045.124 (Official Build) (64-bit) |
hi @stuart-brown, thanks, so then does the player stay black and impossible to start? ( - or is it just that the feature works, and that is is confusing in our menu, just to represent YouTube's default). Please look for errors in the browser console while errors happend and chrome://extensions/?errors=bnomihfieiccainjcjblhegjgglakjdd after they happened - and copy the DOM (the <html> element in the top (screenshot above), and the html source ( ctrl+U) ...please stay alert guy & let us know if you catch the issue #1809 or any... thanks! |
Hi. No the screen is not black, it shows the preview image. But the play button does nothing, the video never plays. It is not a case of confusing configuration. I did not see any errors in the extension page (chrome://extensions/?errors=bnomihfieiccainjcjblhegjgglakjdd). I have attached the errors from the browser console.
Hope this helps clear things up. |
TYSM @stuart-brown!! hopefully we figure it out! (And the amount of uninstalls remains a riddle, a bug with autoplay most single features may result in fewer uninstalls) |
hi! @raingart thank you, not sure i understood. did you implement that? |
Here are a few observations I've made, which could be totally wrong: What seems to be happening is YT detecting that you're using an adblock and flagging your account either with a cookie, internally, or both. This results in the player not loading a video, or taking a while to load with a weird, almost blank screen and then having the video paused after the whole page has loaded. Okay, why does disabling the addon help for some people then? I don't know, but somehow it can be tracked and linked to your account and/or cookies identifier. Even if it did, the same behavior would probably occur eventually. Things I've tried:
Also when this starts happening and you open videos in a new tab (middle click), the addon will fail to set video volume if you have a default one set (and of course autoplay), but player size is set correctly. If you open a video in the same tab you're already on (left click), everything works just fine including page loading and autoplay. Most of this has been said before, but I just wanted to clarify that it probably is just YT detecting you adblocking and screwing things up until you clear cookies or use a different method. To clarify this is with Firefox and could be completely different for other users, I haven't really kept up with things lately. One way to semi fix this might be to detect this happening and re-initialize autoplay/volume and whatever else |
hi! @PoorChameleon
after you manually confirmed the alert?
(or maybe it could be detected before the first try)
lets tag the people from the recent issues about autoplay, volume, etc. to discuss this. |
(uninstalls /re-installs are still increased.) |
Sorry if this is old but ive had ImprovedTube disabled for months because of this issue and turning Autoplay on worked for me |
hi! also using brave? @JLewis1309 reinstalls/uninstalls still seem slightly increased, so will have a close look after editing our feature to disable auto play. (and we should re-structure all features to clean/reduce Youtube, since it might confuses if the switch is representing youtube's default directly (instead of calling our feature "autoplay-off") |
I'm using Firefox, and with version 4.615, I can confirm that with the "Autoplay" setting off, the video will not start, instead playing a few milliseconds of the video before pausing again (when the video is opened in a new tab). However, when clicking on a video from the homepage, I haven't had this problem. video.mp4The attached video should show the difference between opening the video in a new tab and clicking on a video from an already loaded tab. Turning on "Autoplay" fixed this issue for me. |
hi, @ugackMiner53 thank you! our autoplay:off function itself should now only try once (global variable): youtube/js&css/web-accessible/www.youtube.com/player.js Lines 2 to 4 in 7f9e9bb
... youtube/js&css/web-accessible/www.youtube.com/player.js Lines 18 to 22 in 7f9e9bb
code is also prepared to pause here: youtube/js&css/extension/init.js Lines 92 to 95 in 727f824
does it depend what youtube account? - #1851 (then you can look up all the experiements YouTube activated for that account) |
..please try old versions, starting with 3.9xx, two years ago @ugackMiner53 @Evoden1 @ballo @xeophyte @Anoaxx , (https://addons.mozilla.org/en-US/firefox/addon/youtube-addon/versions/ ) thanks! |
hi! @ugackMiner53 @stuart-brown @JLewis1309 |
For me on Firefox 124 and IYT v4.805 autoplay doesn't work, v3.901 also doesn't work, without IYT extension also doesn't work. |
"amazing" 🤣 |
Sorry for late reply |
thanks! what about
|
hi :) @code-charity/contributors ( "assignments" are just a vain hope.. "random ping" )
<html>
when errors appear after pressingF12
TYSM! ♥
The text was updated successfully, but these errors were encountered: