Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube's Embedded Player: 2. show suggestion in the same window (no popup, same for those appearing at the end of videos) (Done: 1. Hide Overlay suggestions (on pause)) #867

Open
2 of 6 tasks
ImprovedTube opened this issue Apr 12, 2021 · 4 comments
Labels
bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@ImprovedTube
Copy link
Member

ImprovedTube commented Apr 12, 2021

2. Same player / No popup (will also improve our popout player)

Greazii

  • no url bar for our popup player
  • open links in same window
  • naming 🤔 disallow youtube to open a new tab for related videos from embedded player (on twitter etc) & or our popup player

1. many people are annoyed by this overlay in embedded players

youtube embedded overlay

  • div class="ytp-pause-overlay ytp-scroll-max" data-layer="4" style="" h2...div class="ytp-suggestions" style="height: 77px;

  • how should it be called...? i.e. "Remove related/suggested Videos in embedded player" and when enabling give a dialog: "switch off related videos on www.youtube.com too (sidebar)?") 🤔


@ImprovedTube ImprovedTube added the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Apr 12, 2021
@ImprovedTube
Copy link
Member Author

ImprovedTube commented Apr 12, 2021

  • on naming:

by @JuniorGenius: (migrated thread)

Something like "Suggested Videos Popup" sounds good to me!
I think the code I used for #829 could be used for this fairly easily.


This is a bit off-topic, but it reminds me of something I was thinking of making a PR or issue for; naming conventions of
features. There are a lot of features that are misleadingly labeled, and I think the biggest part of this is features that are on by default and disable something. In my opinion, they should all be off by default, and renamed to something like "Disable [x]".
A good example of this is "Autoplay" (which also seems to have multiple meanings throughout the UI.
I believe it can lead to confusion because users may assume that this is a feature being added by the extension, rather than the extension disabling a feature already on YouTube.

Should I create a pull request with proposed changes, or would you rather I create a new issue first?

Anyway, sorry for the off-topic ramblings!"

@ImprovedTube
Copy link
Member Author

ImprovedTube commented Apr 12, 2021

= top/loved features to be completed: related videos: hide (sidebar) suggested videos: hide (searchresults)
all three combined in one, saving space: (all) related/suggested videos: hide
then 3 suboptions can appear: [x] sidebar [x] embedded player pop-up on pause [x] search results

(few % of users & uses are "advanced")


on by default

it can be intuitive showing youtube's defaults (short without negation) #719
active features markup #848 (reply in thread) ? (did you see active features list? top right settings)

off-topic ramblings

sure you started?😅

@ImprovedTube ImprovedTube added Feature request Wish or idea 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) labels Apr 12, 2021
@urfausto
Copy link
Contributor

urfausto commented Apr 12, 2021

that one's annoying, surely. 😆

@ImprovedTube
Copy link
Member Author

ImprovedTube commented Sep 29, 2022

( 1. in short: #1292 )
welcome! @ArmandDelessert

@ImprovedTube ImprovedTube added the up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ label Sep 30, 2022
@ImprovedTube ImprovedTube moved this to Todo in Priority A Oct 20, 2022
@ImprovedTube ImprovedTube changed the title overlay suggestions in embedded player paused Youtube's Embedded Player: Hide Overlay suggestions Nov 25, 2022
@ImprovedTube ImprovedTube changed the title Youtube's Embedded Player: Hide Overlay suggestions Youtube's Embedded Player: 1. Hide Overlay suggestions (on pause) AND/OR 2. show them in the same player (no popup, same for those appearing at the end of videos) Dec 2, 2022
@ImprovedTube ImprovedTube changed the title Youtube's Embedded Player: 1. Hide Overlay suggestions (on pause) AND/OR 2. show them in the same player (no popup, same for those appearing at the end of videos) Youtube's Embedded Player: 2. show them in the same player (no popup, same for those appearing at the end of videos) (Done: 1. Hide Overlay suggestions (on pause)) Sep 30, 2023
@ImprovedTube ImprovedTube changed the title Youtube's Embedded Player: 2. show them in the same player (no popup, same for those appearing at the end of videos) (Done: 1. Hide Overlay suggestions (on pause)) Youtube's Embedded Player: 2. show suggestion in the same window (no popup, same for those appearing at the end of videos) (Done: 1. Hide Overlay suggestions (on pause)) Sep 30, 2023
@ImprovedTube ImprovedTube added the good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* label Oct 19, 2023
@ImprovedTube ImprovedTube added the bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) label Nov 5, 2023
@ImprovedTube ImprovedTube added the List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Status: Todo
Development

No branches or pull requests

2 participants