Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync YouTube's native dark theme setting with ImprovedTube's #93

Closed
quenz opened this issue Sep 25, 2019 · 4 comments
Closed

Sync YouTube's native dark theme setting with ImprovedTube's #93

quenz opened this issue Sep 25, 2019 · 4 comments
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Milestone
Medium difficulty...

Comments

@quenz
Copy link

quenz commented Sep 25, 2019

You can toggle YouTube's native dark theme in your user icon menu (top right). I think this should sync with ImprovedTube's dark theme setting by default.
@ghost ghost added the Feature request Wish or idea label Oct 27, 2019
@ghost ghost added enhancement (medium) and removed Feature request Wish or idea labels Apr 13, 2020
@User198263321
Copy link

If you toggle any themes in improved tube in my experience, it will screw it up if using google's dark mode in youtube

@ghost ghost removed the medium label Dec 11, 2020
@ImprovedTube ImprovedTube added the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Dec 13, 2020
@ghost ghost removed the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Dec 13, 2020
@hboyd2003 hboyd2003 added this to the Medium / typical milestone Sep 30, 2022
@ImprovedTube ImprovedTube added up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* labels Oct 19, 2023
@ImprovedTube
Copy link
Member

our "dark" button is only setting youtube's dark theme, by YouTube's cookie.
moved it down to be our last theme option

ImprovedTube added a commit that referenced this issue Feb 4, 2024
@ImprovedTube
#93
71f56b4
@ImprovedTube ImprovedTube mentioned this issue Mar 7, 2024
Closed
@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Mar 23, 2024 •
edited
Loading

#93 (comment)

@quenz, this shouldn't be synchronized with YouTube. It should be synchronized with the browser, which YouTube inherits it from, and which inherits it from the desktop environment.

@raszpl
Copy link
Contributor

raszpl commented Jun 16, 2024

implemented in #2253 9f4bfa0

@raszpl raszpl closed this as completed Jun 16, 2024
@raszpl raszpl mentioned this issue Jun 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Milestone
Medium difficulty or typical complexi...
Development

No branches or pull requests
6 participants
@raszpl @hboyd2003 @quenz @ImprovedTube @RokeJulianLockhart @User198263321