-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Issue #1395 #1396
Fixed Issue #1395 #1396
Conversation
Dear @hboyd2003, thank you again! ⭐ and so sorry to delay the complete reaction! (i didnt expect our hero contributor & maintainer to pause #1405) (and i didnt write this feature.) why are you making a second API request? |
@ImprovedTube The original code takes the URL to the channel and pulls the channel ID from that then uses the ID to make an api request. The issue comes when a channel has a custom channel URL thus the channel ID is not in the URL. So a api request that uses the video ID to then get the channel ID works best. Its possible (and probable) that the channel ID does exist somewhere on the page but I could not find it. I’ll add a check to test if the url is a custom url or not so we can cut down on API requests. |
@ImprovedTube It should now only make two API requests when a user has a custom channel ID |
Thanks!! This will cut confusions a lot soon. |
Fixed the channel video count