Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #1553 #1572

Merged
merged 3 commits into from
Feb 17, 2023
Merged

fixed issue #1553 #1572

merged 3 commits into from
Feb 17, 2023

Conversation

MohamedLebda
Copy link
Contributor

Added mouse event so that when the mouse stops it hides the controls.

@ImprovedTube
Copy link
Member

thank you! @MohamedLebda
Youtube's default for that is longer ~ 3 seconds

BTW, shouldn't we only add eventListeners when an option is activated?
( originally #1331 @JuniorGenius
https://github.com/code-for-charity/ImprovedTube-for-YouTube/blob/102eea7b30a0a6010ee7ab473452a4bae2421392/content-scripts/website-context/youtube-features/player.js#L1138-L1158 )

@MohamedLebda
Copy link
Contributor Author

Changed the code, Now the event listeners will only work when choosing when paused option.

@ImprovedTube
Copy link
Member

thank you so much @MohamedLebda, looking forward!

@ImprovedTube ImprovedTube merged commit ba7c738 into code-charity:master Feb 17, 2023
@ImprovedTube
Copy link
Member

Hi @MohamedLebda, it works when we make the setting (Storage changed) but not afterwards.
Not sure why #1331 @JuniorGenius put the eventlisteners in the init.js in the first place. The whole feature could stay one function no matter how many options(?)

ImprovedTube added a commit that referenced this pull request Apr 2, 2023
ImprovedTube added a commit that referenced this pull request Apr 2, 2023
ImprovedTube added a commit that referenced this pull request Apr 2, 2023
ImprovedTube added a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants