Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #1552 #1603

Merged
merged 1 commit into from
Mar 10, 2023
Merged

issue #1552 #1603

merged 1 commit into from
Mar 10, 2023

Conversation

MohamedLebda
Copy link
Contributor

there are two functions with the id chat
chat-1552
chat-1552-1
the first one sets the button that is supposed to be clicked to collapse the chat and the second one doesn't have the button so it sets the button to null
liveChat-1552

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 10, 2023

console.log(document.querySelector('[aria-label="Hide chat"]'))

(to remove)

isCollapsed

(our feature is rarely disabled, let alone expected to take effect the same moment.
yet let & if can run billions of times per second, so it is worth it after all.)

( #1590 can also be fixed)

@ImprovedTube ImprovedTube merged commit 934253c into code-charity:master Mar 10, 2023
@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 10, 2023

(

console.log(document.querySelector('[aria-label="Hide chat"]'))

removing

isCollapsed

feature is rarely disabled let alone expected to take effect the same moment. yet let & if can run billions of times per second, so it is worth it.
)

ImprovedTube added a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants