forgot theme default case

[raszpl]

all that boasting about ""this time working" and I forgot default case #2076

[ImprovedTube]

hi @raszpl!

myColors()

I combined it with theme switching

where?

the call needs to stay in init.js 0bf8911
while custom colors are set by JS.

thats why it should also stay a separate function ( myColors() )

---

btw, what about activatating custom colors and a theme advance / separately, to overwrite some of the themes colors?

[raszpl]

the call needs to stay in init.js

Yes I see it now. Whole setTheme() needs to be called from init.js. because it does more than just colors in 'custom', it also needs to be able to change f6 cookie: there is a possibility of user switching theme in YT to light while improvetube is set to dark. This will screw colors up without letting the user know why colors are bad. With setTheme() being run at init cookie will be kept in sync with Theme.

0bf8911

indentation! #2106

btw, what about activatating custom colors and a theme advance / separately, to overwrite some of the themes colors?

can you elaborate?

[ImprovedTube]

can you elaborate?

Custom colors and presets need not be mutually-excluding. "custom" can look different.
A user could 1. Select a preset 2. select a custom colors too. While the other way around could toggle:off all the custom colors (like we did for other toggles, or ask if it was on another screen)
@raszpl

[raszpl]

Ah, additional customization of pre-set themes. Im not big on colors and customization. If you come up with some framework I can polish it up..