-
-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocklist overhaul for testing #2098
Conversation
separate .it-blocklisted-channel
dynamically updated on all pages, can turn on/off and see results live without reloading page. Channel blocklist works now where channel info available in thumbnail container.
Sorry if this is the wrong place to ask, but how do I use the blocklist feature? There's a button to activate it but I don't see anyway to add channels into the blocklist |
its half broken at the moment in official extension. Thats what Im trying to fix :)
I dont have strong opinions about this, just corrected according to common English grammar rules https://gallaudet.edu/student-success/tutorial-center/english-center/grammar-and-vocabulary/definite-and-indefinite-articles/when-to-use-a-an-or-the/
In 4.804: no visual feedback, no screen update again no updates on the screen |
looking forward to merge all your work!
💡 +"when the user" 308 million |
618ab26
to
579628d
Compare
62a36d2
to
40aedd4
Compare
heh, its been what, 2 months and its already stopped working, YT changed things around, for example Subscribe button on channel page is no longer 'YTD-SUBSCRIBE-BUTTON-RENDERER' but 'YT-SUBSCRIBE-BUTTON-VIEW-MODEL' :/ |
fixed it up and synced to master #2244 |
hi! @raszpl |
I dont quite understand what was merged here :o It tells me both #2098 and #2244 got merged, but only one of those had fixed code ?!?! confusing github
I only see YTD-SUBSCRIBE-BUTTON-RENDERER on video pages parentNode of YTD-SUBSCRIBE-BUTTON-RENDERER had .__dataHost.__data.data containing all the stuff we are interested in, channel name etc. Those new buttons dont have any data associated with them, I had to switch to ytInitialData.metadata.channelMetadataRenderer Its crashing on video pages now because it cant detect which one is channel, fix #2246 |
Dynamically updated on all pages, can turn on/off and see results live without reloading page. Channel blocklist works now where channel info available in thumbnail container.
Might still break on some subpages, needs more extensive testing.