-
-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update styles.css --yt-searchbox-background -> --ytd-searchbox-backgr… #2143
Conversation
custom was missing --ytd-searchbox-background --ytd-searchbox-legacy-button-color
need to cover [dark] too because this code runs too early for document.querySelector('ytd-masthead')?.removeAttribute('dark'); loading page with YT dark cookie and Custom theme generates ytd-masthead after myColors() and slaps [dark] attribute on it
Guess it can be replaced somewhere along the path and maybe it still exists on some systems or with some of Youtube's experiment flags? |
can always go extra safe and keep both |
what might it mean? considering view-source:
|
|
"need to cover [dark] too because this code runs too early for document.querySelector('ytd-masthead')?.removeAttribute('dark'); loading page with YT dark cookie and Custom theme generates ytd-masthead after myColors() and slaps [dark] attribute on it" TLDR set YT cookie to dark, set custom theme, myColors() is being called somewhere early in core.js before YT adds [dark] to ytd-masthead, as a result
can delete those lines after testing CSS covers everything |
YT no longer uses --yt-searchbox-background, its renamed to --ytd-searchbox-background. Fixes searchbox color in all themes