Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update themes.js normalizing, removing redundant data #2170

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Update themes.js normalizing, removing redundant data #2170

merged 2 commits into from
Apr 9, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Apr 8, 2024

can remove

"default_theme": {
    "message": "default"
},

from all locales

raszpl added 2 commits April 8, 2024 19:52
can remove

    "default_theme": {
        "message": "default"
    },

from all locales
@ImprovedTube
Copy link
Member

can do that with our py/locale.py -remove default_theme and/or crowdin or @unnamed-orbert
after checking each translation. Possibly some might translated default_theme, but didn't translate default yet

@ImprovedTube ImprovedTube merged commit 04a604b into code-charity:master Apr 9, 2024
@unnamed-orbert
Copy link
Contributor

Update the locales/en to me, to sync all others files! @ImprovedTube

@ImprovedTube
Copy link
Member

ImprovedTube commented Apr 9, 2024

Possibly some might translated default_theme, but didn't translate default yet

..and we can first rename default_theme to default with py/locale.py -change-key, if we make that feature not overwrite anymore or ask

if old_key in data:

@raszpl raszpl deleted the patch-7 branch April 9, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants