Update themes.js no more cookie, no more [dark] dependence

[raszpl]

no more cookie, no more [dark] dependence
text-inverse should be different from text, related to #2150

[ImprovedTube]

• then our "dark" & "default" buttons do nothing anymore and shall be removed or summed up as one "none"?
  • or we can have a 3-ways switch for 3 options (Youtube's dark OR light OR system-default), just like youtube already has as said in Extension disabling Youtube dark mode #2138, since cookie code is ready and editing it once seems enough.

---

related /BTW: idk why, when a theme is set already, then our dark theme shortcut might only makes the search field black (

youtube/js&css/web-accessible/www.youtube.com/shortcuts.js

Line 624 in 87aa7e4

ImprovedTube.shortcutDarkTheme = function () {

) - it could just stay youtube's dark or our black - or the previously selected opposite light / dark as for #2161

[raszpl]

• then our "dark" & "default" buttons do nothing anymore and shall be removed or summed up as one "none"?
  • or we can have a 3-ways switch for 3 options (Youtube's dark OR light OR system-default), just like youtube already has as said in Extension disabling Youtube dark mode #2138, since cookie code is ready and editing it once seems enough.

Can be reworked to 3 separate entries in Themes:
1 "none/no change/default/disabled" left as is doing nothing. The default state with extension just installed.
2 "YT dark" forcing YT Dark theme without touching cookies
3 "YT light" forcing YT Light theme without touching cookies

After all the cookie trouble its safest to just remove that code altogether and do all overrides with pure CSS.
Currently 2 and 3 dont work at all yet, but its easy to fix that.

related /BTW: idk why, when a theme is set already, then our dark theme shortcut might only makes the search field black (

I havent touched shortcuts so no idea whats wrong there. After themes are fixed and solid shortcutDarkTheme should just switch themes without doing anything beyond. Can even let user configure two themes it would be switching between, same goes for #2161

[raszpl]

btw

youtube/js&css/web-accessible/www.youtube.com/themes.js

Line 5 in 8e41763

if ( this.storage.theme === 'custom' && Array.isArray(this.storage.theme_primary_color) && Array.isArray(this.storage.theme_text_color)) {

check for Array.isArray(this.storage.theme_primary_color) && Array.isArray(this.storage.theme_text_color) is not required, because

youtube/js&css/web-accessible/www.youtube.com/themes.js

Line 13 in 8e41763

primary_color = 'rgb(200, 200, 200)';

youtube/js&css/web-accessible/www.youtube.com/themes.js

Line 19 in 8e41763

text_color = 'rgb(25, 25, 25)';

but we need a better place to store default Custom theme colors, currently its also in here

youtube/menu/skeleton-parts/themes.js

Line 75 in 8e41763

value: [200, 200, 200]

youtube/menu/skeleton-parts/themes.js

Line 80 in 8e41763

value: [25, 25, 25]

ideally it should be in one central place. Also default Custom theme colors suck a little :) its just black and gray making it look just gray while Theme "Custom" button is Red :o Would be nice to make the "Custom" button reflect currently selected custom colors.