Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate shortcut updated #2303

Merged
merged 4 commits into from
May 25, 2024
Merged

Conversation

agrpranjal07
Copy link
Member

#Fixed #1699
Rotate shortcut issue fixed
the button is removed as told in #2302

agrpranjal07 and others added 4 commits May 24, 2024 19:04

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ImprovedTube ImprovedTube merged commit c6f6fc8 into code-charity:master May 25, 2024
@ImprovedTube
Copy link
Member

hi! @agrpranjal07
to be more precise: we only need the function of the button, not the button. #1699 (comment)

  • it would be ok to have the button, if somebody forgot they set the shortcut, yet maybe not everyone who wants the shortcut wants the icon then. or the button as feedback could be a sub-option of the shortcut

And we can't set a default "r" (for everybody, unless we would also have a toggle ON/OFF for the shortcut.)


Please let us know if anything comes to mind how to manage our UX to keep it efficient & nice.

@agrpranjal07
Copy link
Member Author

@ImprovedTube
Adding a toggle button on top of the shortcut menu named Disable shortcut can resolve the issue and give users more control and choices whether they wanna use the shortcuts or not. According to my experience as a user, it will increase user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can you please assign a key to the rotate video option ?
2 participants