Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captions rename for live updating, add option to force disable #2385

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Captions rename for live updating, add option to force disable #2385

merged 7 commits into from
Jun 17, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Jun 16, 2024

new options, compatible with old user settings

player_subtitles: {
	text: 'auto' default YT behavior (yt detects user language and decides on its own)
	text: 'enabled' always enables 
	text: 'disabled' always disables

Can switch live without reloading page.

subtitlesLanguage no longer forces subtitles on
subtitlesUserSettings apply even when disabled - turned on later will have settings already applied

raszpl added 2 commits June 16, 2024 13:38

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@raszpl raszpl marked this pull request as ready for review June 16, 2024 12:27
@raszpl raszpl changed the title Update player.js rename for live updating, add option to force disable Captions rename for live updating, add option to force disable Jun 16, 2024
@ImprovedTube ImprovedTube merged commit 2e850c8 into code-charity:master Jun 17, 2024
1 check passed
@raszpl raszpl deleted the patch-15 branch June 17, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants