Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: rename js&css directory #2391

Closed
wants to merge 36 commits into from

Conversation

4yman-0
Copy link

@4yman-0 4yman-0 commented Jun 18, 2024

This PR removes the need for js&css since every directory (extension, menu etc.) has js and css subfolders. www.youtube.com was also renamed to yt.be.

edit: d942d8f and ae968c7

@ImprovedTube
Copy link
Member

hi! and thanks @4yman-el js & css are friends, stuff is short

@4yman-0
Copy link
Author

4yman-0 commented Jun 18, 2024

stuff is short

OK, i'll rename it again

@4yman-0
Copy link
Author

4yman-0 commented Jun 18, 2024

How about res?

@ImprovedTube ImprovedTube marked this pull request as draft June 19, 2024 04:33
@raszpl
Copy link
Contributor

raszpl commented Jun 20, 2024

One one hand modern file systems can handle & no problem, on the other hand separating CSS to its own directory does feel much cleaner and nicer.

@4yman-0 4yman-0 marked this pull request as ready for review June 20, 2024 15:35
@ImprovedTube
Copy link
Member

TYSM again! 4yman-el i'm story to be 'stubborn' this time to delay this in favor of our habit clicking through exactly this structure for right now and once we change it then we might change more. (Draft is not what i meant but #later or #optional-inspiration)

(and the price renaming costs, is adding an extra page to to edit histories on github to each of the files)

before doing much more of this i would like to prepare command lines still to rewrite the commit history most conveniently. (or hope to find the perfect ready made tool for that)

on the other hand separating CSS to its own directory does feel much cleaner and nicer.

yet hardly separated on the client-side. @raszpl / Some of the css&js pairs /neighbors might be edited at once. i'd consider to mix in html, json, sql(-lite), csv at need & call the folder (browser-)code.

And, not said yet: Since this project sometimes is about entertainment (youtube) and young users, it would makes sense that the naming fit a bit of a broader audience (rare/new/hobby developers) who might also potentially fix something little sometimes.

@ImprovedTube
Copy link
Member

Makes sense for today?
Wish i could already /first make productive contributors reply to bigger concepts /visions like:

@ImprovedTube ImprovedTube added the Later Relevant and or inspiring, just temporarily coliding with daily routines. label Jun 20, 2024
@4yman-0

This comment was marked as resolved.

@4yman-0

This comment was marked as resolved.

@ImprovedTube
Copy link
Member

@4yman-el you chose

@ImprovedTube
Copy link
Member

ImprovedTube commented Jun 25, 2024

inviting you to the organisation so that you can set labels in future (or assign. or close duplicates)

@ImprovedTube ImprovedTube added the Structures (UX & ORG) Let's focus on structure! Everything should be as easily seen/found as it is relevant. label Jun 25, 2024
@4yman-0
Copy link
Author

4yman-0 commented Jul 4, 2024

thanks for 8cab0ca!

@4yman-0 4yman-0 closed this Jul 17, 2024
@4yman-0 4yman-0 force-pushed the refactor/rename_js_css branch from c8862c6 to e5370a0 Compare July 17, 2024 14:43
@4yman-0 4yman-0 reopened this Jul 17, 2024
@4yman-0
Copy link
Author

4yman-0 commented Jul 17, 2024

@ImprovedTube Please review now.

@4yman-0
Copy link
Author

4yman-0 commented Jul 18, 2024

Each PR has its own purpose, please merge or push to master instead of this fork/branch. I was confused by the commits named typo, - etc.
edit: small typo

@4yman-0 4yman-0 closed this Aug 27, 2024
@4yman-0 4yman-0 deleted the refactor/rename_js_css branch August 27, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Later Relevant and or inspiring, just temporarily coliding with daily routines. Structures (UX & ORG) Let's focus on structure! Everything should be as easily seen/found as it is relevant.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants