Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messages.json "Toggle player controls Hiding" #1129 #2409

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Update messages.json "Toggle player controls Hiding" #1129 #2409

merged 1 commit into from
Jun 26, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Jun 23, 2024

No description provided.

@ImprovedTube
Copy link
Member

toggle is a technical word, not very popular.
https://trends.google.com/trends/explore?date=all&q=toggle,button,enable,disable,hide
so that we could replace it with on/off

@raszpl
Copy link
Contributor Author

raszpl commented Jun 26, 2024

I mean as technical as a light switch, word is from 1700 https://www.oed.com/dictionary/toggle_n :) but whatever :-] the important bit is somehow letting user know this doesnt switch player controls, but current active "Hide player controls bar" mode. Afaik 'player control bar' is internally controlled by YT library and I couldn't find a way of forcing it always on.

@ImprovedTube ImprovedTube merged commit e1c339d into code-charity:master Jun 26, 2024
1 check passed
@ImprovedTube
Copy link
Member

ImprovedTube commented Jun 26, 2024

hi @raszpl , yes (+many people in non-english speaking places might not know what a toggle is & it is a relatively young word used since ~200 years ago https://books.google.com/ngrams/graph?content=toggle%2Cbutton%2Camazing&year_start=1500&year_end=2019&corpus=en-2019&smoothing=0 )

@raszpl raszpl deleted the patch-5 branch June 26, 2024 22:09
@raszpl
Copy link
Contributor Author

raszpl commented Jun 26, 2024

~300 years, and thats pretty much how old most of modern English is. If you ever get your hands on a time machine dont go further back than ~400 years if you dont know Latin :P

@ImprovedTube
Copy link
Member

200! @raszpl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants