-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YTD total to fct_monthly_active_students #242
Conversation
Just for the sake of comprehensiveness - this is double-counting students who use the platform on consecutive months. I need the school year to date numbers for unique students. So something like: This is answering this question: |
… feature/add_ytd_to_fct_active_students
… feature/add_ytd_to_fct_active_students
- editing the sum for ytd to be the active students ytd rather than active_students
I found two issues in the previous version:
I pushed a commit to fix those two things. It was a breaking change, as my version does not run. There's an error with the last CTE, I think with the partition formatting. But the logic up in the CTEs above (up through final) should now be working, so hopefully the issue in the rolling_final an easy fix. Can you look at this again and see if you can figure out the partition logic in the last step? |
… feature/add_ytd_to_fct_active_students
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great - thanks!
Description
Add school_year to date total to rows in
fct_monthly_active_students
Links
Jira ticket(s): DATAOPS-1068
Testing story
Example for this school_year, US:
cc @coryamanda
eg.
-
not_null
-
unique
- `dbt_utils.unique_combination_of_columns: , ["value","value","value"...]
Note: when submitting a new model for review please make sure the following have been tested:
dbt build -m 'your_model'
)or: has the dbt Cloud job succeeded?
dbt run -m 'your_model'
)select 1 from 'your_model'
)Privacy
i.
ii.
iii.
PR Checklist:
--> Note: if these are not all checked, the PR will be sent back.
.yml.
, diddbt docs generate
succeed?)dbt docs
has been updated successfully on Github Pageschore/
,feature/
,fix/
)