-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dim_user_levels to include content_area and topic_tags #244
Update dim_user_levels to include content_area and topic_tags #244
Conversation
1. Adding content_area and topic_tags to dim_user_levels 2. Change to staging scripts layer to define content_area as 'other' when null to make it consistent with the logic we use for course_names where nulls are defined as 'other'
QA'd by
Code used for QA: 1.a
1.b.
|
… feature/update_dim_user_levels_content_fields
case | ||
when course_name = 'hoc' | ||
then 'hoc' -- If course_name is HOC, content area is HOC too | ||
when nullif(content_area,'') is null then 'other' -- If content area is null then 'other' to align with course_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably a @jordan-springer question, but any difference between this statement and when content_area = ''
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The CI run was successful, and then I updated the branch, kicking off another CI run. Approving now assuming that is also successful.
@jordan-springer ready for you to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There's two changes in this PR:
content_area
andtopic_tags
todim_user_levels
Jira ticket(s): DATAOPS-1082