Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/clean_up #39

Merged
merged 3 commits into from
Dec 6, 2023
Merged

chore/clean_up #39

merged 3 commits into from
Dec 6, 2023

Conversation

jordan-springer
Copy link
Collaborator

Description

Please include a summary of the change, including any relevant background, motivation, and context.

If relevant, include a description, screenshots, etc. of new behavior/model/update/...

Links

Jira ticket(s):

Testing story

  • Does your change include appropriate tests?
    eg. not_null, unique

Note: when submitting a new model for review please make sure the following have been tested:

  1. The model compiles (dbt compile -m 'your_model')
  2. The model runs (dbt run -m 'your_model')
  3. The model produces accessible data in the DW (select 1 from 'your_model')

Follow-up work

Any related, outstanding, blocking, or follow-up work:

Privacy

  • 1. Does this change involve the collection, use, or sharing of new Personal Data?

  • 2. Does this change involve a new or changed use or sharing of existing Personal Data?

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code adheres to style-guide and is DRY
  • Code is well-commented
  • New features are translatable or updates will not break up/downstream models
  • Relevant documentation has been added or updated
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@jordan-springer jordan-springer merged commit 91ab4db into main Dec 6, 2023
@jordan-springer jordan-springer deleted the fix/user_levels branch December 6, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant