fix/dim_teachers #65
Merged
fix/dim_teachers #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakerfranke
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
LGTM. This interacts with an open PR I have right now, but I don't think it conflicts.
Overall, I agree that adding this pii is inevitable for our internal use cases. I'm not sure how we should manage from a security/privacy standpoint.
A future solution would be to make something like a dim_users_pii table that we could limit access to (somehow) and instruct people to only join to it if they need the PII.
|
how do we feel about putting this model (and its nodes) in the |
jordan-springer
approved these changes
Jan 24, 2024
jordan-springer
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the fix?
Add PII info (email, username, name) to dim_teachers and make underlying staging model incremental.
Why?
Marketing is often needing to pull teacher email addresses (and sometimes names) based on whether or not they still use code.org. Our models would allow them to do this if these PII fields were added to dim_teachers. This PII is already made available to them (and the org) through various google sheets, so was approved by Travis to be user-facing in Trevor. No PII is in the code itself.