hoc2023: initial work #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though canvas removed due to difficulties building in my env.
Hamms
approved these changes
Sep 19, 2023
| - name: Build | ||
| run: npm run build | ||
| run: yarn run build |
There was a problem hiding this comment.
Nit; I believe you can omit run from yarn commands; ie, yarn dev rather than yarn run dev. yarn run still works, though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
dance-partyrepo to build with the same key tooling as our main repo. In particular, it now builds withnodeversion18.16.0, usesyarninstead ofnpm, and useswebpackversion5.I believe that for Ubuntu builds, tests requires Ubuntu 20.04 or later, rather than 18.04 (which our main repo's drone docker image still uses), because the
canvascomponent requires GLIBC 2.28 or later, and Ubuntu 18.04 only has GLIBC 2.27. The GitHub Actions used to test PRs in this repo currently get Ubuntu 22.04.The trickiest part of this change was getting the
test:integrationcomponent of the tests running again. It uses Karma, which is now deprecated, but is at least now at the latest version. A number of tricks were needed to make it work again with all of these latest versions. I took a cursory look at a couple alternatives, but Karma offered the convenience of preprocessing withwebpack, invocation of headless chrome, and does still work.