Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoc2023: prettier JS files #647

Merged
merged 3 commits into from
Sep 19, 2023
Merged

hoc2023: prettier JS files #647

merged 3 commits into from
Sep 19, 2023

Conversation

breville
Copy link
Member

@breville breville commented Sep 15, 2023

This updates the formatting of all JS files in this repo, in preparation for additional updates for hoc2023.

Copy link
Contributor

@fisher-alice fisher-alice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for prepping for the upcoming changes. I am curious - were you able to make all the 'prettier' changes automatically? I see you added the configuration to .prettierrc.js after you made the file updates.

@breville
Copy link
Member Author

Thanks for prepping for the upcoming changes. I am curious - were you able to make all the 'prettier' changes automatically? I see you added the configuration to .prettierrc.js after you made the file updates.

I applied these in an editor, one file at a time, but presumably there is a way to do this by batch in the command line. I had the prettierrc.js file there the whole time, but didn't commit it until later.

@fisher-alice
Copy link
Contributor

Thanks for prepping for the upcoming changes. I am curious - were you able to make all the 'prettier' changes automatically? I see you added the configuration to .prettierrc.js after you made the file updates.

I applied these in an editor, one file at a time, but presumably there is a way to do this by batch in the command line. I had the prettierrc.js file there the whole time, but didn't commit it until later.

Oh gotcha - thanks!

@fisher-alice
Copy link
Contributor

General question - will we bump up the version after all the hoc updates?

@breville
Copy link
Member Author

General question - will we bump up the version after all the hoc updates?

We will bump the version each time we have a new build that we want to be consumed by our main repo, which I think should be done regularly once we have momentum.

@breville
Copy link
Member Author

I went ahead and did the other JS files in the repo too.

@breville breville changed the title hoc2023: prettier src files hoc2023: prettier JS files Sep 17, 2023
Copy link
Contributor

@fisher-alice fisher-alice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@breville breville merged commit a3b32a1 into main Sep 19, 2023
2 checks passed
@breville breville deleted the hoc2023-prettier-src branch September 19, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants