Remove redundant reset call in playSound onEnded callback #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 17, 2023 18:39
8 tasks
fisher-alice
changed the title
breville
approved these changes
Sep 19, 2023
added 2 commits
September 19, 2023 13:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pairs with code-dot-org/code-dot-org#53817 which adds the ability to configure a preview for the 'setup' blocks on Dance Party levels.
In this PR within
p5.dance.jsI removed a call toresetin theonEndedcallback forplaySound. This is a redundant call toresetand caused an issue when preview is enabled - sometimes, the preview did NOT show up when the 'reset' button is clicked because theplaySoundonEndedcallback which included theresetcall would be executed AFTER the preview was drawn.