Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoc2023: AI modal #652

Merged
merged 5 commits into from
Sep 27, 2023
Merged

hoc2023: AI modal #652

merged 5 commits into from
Sep 27, 2023

Conversation

breville
Copy link
Member

@breville breville commented Sep 22, 2023

This adds support for the Dance Party AI modal being added in code-dot-org/code-dot-org#53889.

@breville breville marked this pull request as draft September 22, 2023 05:33
@breville breville marked this pull request as ready for review September 26, 2023 06:46
@breville breville requested a review from a team September 26, 2023 17:12
Copy link
Contributor

@fisher-alice fisher-alice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -1119,7 +1119,25 @@ module.exports = class DanceParty {
}

// Called when executing the AI block.
async ai(value) {
ai(params) {
console.log('handle AI:', params);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to leave this print statements here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have found them useful for development, for now. We can probably remove when we get closer to done.

@breville breville merged commit dce9f20 into main Sep 27, 2023
1 check passed
@breville breville deleted the hoc2023-ai-modal branch September 27, 2023 01:58
@breville breville requested a review from samantha-code October 2, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants