[Salvador Villalon] Add i18n settings translation #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daynew
requested changes
May 21, 2021
i18n/locales/en_us.json
Outdated
Comment on lines
57
to
58
| "saveSettingDescriptorSaveToGallerySaveLocally": "Save to your gallery, save locally", | ||
| "saveSettingDescriptorExportAsFile": "export as a file", |
There was a problem hiding this comment.
We don't want to do this because it make translation very difficult. English sentence structure doesn't match all other languages, so translating this will be very awkward. Instead, we should change piskel to remove the <br> from the middle of the sentences and let the text flow normally in the HTML. If this results in a div/box which is too wide, then we should be setting the CSS property width to limit the size.
Please rework the strings and templates which have <br/> tags in them. Also, check if I missed this in any previous pull requests as well.
Co-authored-by: Dayne <dayne@code.org>
…de-dot-org/piskel into add-i18n-settings-translation Getting new code from pr suggestion
daynew
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change adds translation strings for the settings options.
We use the function fillIntTemplate found in utils/Template.js to help us generate templates with values in them
New templates in misc-templates.html have been added.
settings.html now does not have any static content. Instead, it has comments saying where the context gets created from.
To Note
When I was trying to fill up the templateValues Object. It was not accepting template literals. When I tried doing them, the application will not run. Instead, I went back to doing string concatenation and this worked. I believe it has something to do with the version of js since it did not accept new standards like let or const
Testing Done
In the picture, you can see that the Settings Option now has the TEST N in each text. Highlighted in red. This comes from en_us.json which means that the translation did go through.
We also see that we successfully generated the HTML content and we longer need to write HTML in settings.html
Follow Up
Going to work on Color Palette Tool