Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Salvador Villalon] Add i18n lowercase locale #50

Merged
merged 6 commits into from
May 26, 2021

Conversation

salvillalon45
Copy link

@salvillalon45 salvillalon45 commented May 26, 2021

Overview

This change adds lowercase support to change the passed locale code to lowercase.

It also adds changes where it changes en_us to en_US

Testing Done

I applied this code to double-check everything gets lowercase

window.piskel_locale = 'en_US';
console.log(window.piskel_locale);
console.log(window.piskel_locale.toLowerCase());

The browser console show the first string uppercase and the second string lowercase
image (1)

@salvillalon45 salvillalon45 requested a review from daynew May 26, 2021 19:06
Copy link
Member

@daynew daynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one change needed! Merge after you make the change.

src/js/app.js Outdated Show resolved Hide resolved
Co-authored-by: Dayne <dayne@code.org>
@salvillalon45 salvillalon45 merged commit f1cba96 into add-i18n May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants