Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove refinery-config #266

Merged
merged 22 commits into from
Nov 19, 2024
Merged

Remove refinery-config #266

merged 22 commits into from
Nov 19, 2024

Conversation

anmarhindi
Copy link
Contributor

@anmarhindi anmarhindi commented Nov 5, 2024

PRs

Post PR approval/merge TODO:

  • Archive refinery-config
  • add note to dev channel to remove old current_config file
  • remove current_config file from dev server after merge
  • remove REFINERY_CONFIG & REFINERY from app_version table after merge

before merge

  • discuss with andrea best procedure for migration / merge

2nd Sprint TODO:

Remove the following from all repos linked above:

  • is_demo
  • is_managed
  • allow_data_tracking
  • token (dev-setup reference)
  • limitChecks (refinery-ui reference)

K8 TODO: remove refinery-config from the following:

Start with

bash start -x -b config

api/misc.py Outdated Show resolved Hide resolved
api/misc.py Outdated Show resolved Hide resolved
base_config.json Outdated Show resolved Hide resolved
config_handler.py Outdated Show resolved Hide resolved
config_handler.py Outdated Show resolved Hide resolved
@lumburovskalina
Copy link
Contributor

lumburovskalina commented Nov 14, 2024

Repo for OS version should be also archived? Also discord channel and maybe a message that the OS version is not supported anymore

  • resolved
  • ignored

Lina: The PR was closed unintentionally

JEdit:
No the os version repo etc. are still kept. We also might release a new os version with a different approach but to keep the "stars" etc. everything is kept (in version 1.15). However the refinery repo (os version) should be removed from the refinery-updater version overview

  • resolved

@lumburovskalina
Copy link
Contributor

lumburovskalina commented Nov 14, 2024

I signed up and tried to login but i am getting an error? (and the current_config.json) is not automatically created

Lina updated: even with old current config, couldn't start the app

  • resolved
Screenshot 2024-11-14 at 14 22 34

JEdit: dev-setup didn't have the volume/env var => after a new pull of dev-setup this should be resolved

@lumburovskalina
Copy link
Contributor

lumburovskalina commented Nov 14, 2024

when excluding refinery-gateway i get couldn't notify tokenizer

  • resolved
Screenshot 2024-11-14 at 14 52 42

JEdit:
Expected behavior since the tokenizer service is started after the gateway. Will include a timeout for initial

JEdit v2:
Removed it from startup altogether as the tokenizer collects "on demand"

@JWittmeyer JWittmeyer merged commit 054e88c into dev Nov 19, 2024
1 check passed
@JWittmeyer JWittmeyer deleted the config branch November 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants