Fix typo #2
Merged
Fix typo #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattn
commented
Jun 18, 2022
Closed
Comment on lines
+5
to
+6
| func Default(text string) string { | ||
| return "\x1b[0m" + text |
There was a problem hiding this comment.
Suggested change
| func Default(text string) string { | |
| return "\x1b[0m" + text | |
| // Deprecated: Use Default | |
| func Defalt(text string) string { | |
| return Default(text) | |
| } | |
| func Default(text string) string { | |
| return "\x1b[0m" + text |
どう思いますか？
これでbreaking changeの変更じゃないでしょう。
（「breaking change」を日本語で書き方はわらなくてすみません 😖 ）
|
なんともお恥ずかしいTypoだらけで。。。。ありがとうございます。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
このライブラリを使ってはないですが typo を見付けたので。
関数名が変わっているのでこのライブラリを使っている側の修正も必要です。