Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Increase code quality #28

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Conversation

GitBib
Copy link
Contributor

@GitBib GitBib commented Mar 25, 2022

Began to increase the quality of the code to further increase the functionality

Copy link
Collaborator

@JonasScholl JonasScholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the effort! I think these are some good cleanups 👍 In some cases I personally wouldn't write it the same way, but in most of them I agree 😄 I mean at this point it's mostly personal preference how to write it and how explicit you want to make it. I think most of the code was written as explicit as possible so that everyone can understand it, especially beginners. But if it's still readable and not too complex I'm also rather a fan of writing code as lean as possible 🙂

Copy link
Collaborator

@yannicschroeer yannicschroeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we loose some explicity - and I got some personal discomfort with the walrus operator - but overall I think this improves both code quality and pythonicness. Thank for your contribution!

@yannicschroeer yannicschroeer merged commit 5ff308c into code-specialist:master Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants