Data files fix #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, thanks for your review! I noticed the part about the README too, the example you have given is indeed much better. And makes sense to avoid mentioning distutils directly. Will merge these two commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @codeandfire these are some suggestions I might have mentioned in the review.
These changes regard the existing content (before you started working in the PR), but I am sharing these suggestions with you to see your opinion since you are already working on this text.
(Thanks again for the great contributions).
Summary of changes
READMEto something more realistic (or at least I believe is more realistic...) like.gitattributesdistutilsdirectly since it is being deprecated anyway.Closes
Pull Request Checklist
changelog.d/.(See documentation for details)