Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose minimumTopOffset and minimumContentHeight properties #21

Closed
mpospese opened this issue Apr 24, 2023 · 0 comments · Fixed by #24
Closed

Expose minimumTopOffset and minimumContentHeight properties #21

mpospese opened this issue Apr 24, 2023 · 0 comments · Fixed by #24
Assignees
@mpospese
Labels
enhancement New feature or request

Comments

@mpospese
Copy link
Contributor

Replace these two private properties on BottomSheetController:

    private let minimumTopOffset: CGFloat = 44
    private let minimumContentHeight: CGFloat = 88

with two public properties on BottomSheetController.Appearance.Layout (same default values).

Expand unit tests as needed to maintain 100% code coverage.
@mpospese mpospese added the enhancement New feature or request label Apr 24, 2023
@mpospese mpospese mentioned this issue Apr 26, 2023
Merged
@mpospese mpospese linked a pull request Apr 26, 2023 that will close this issue
[Issue-21] Expose minimumTopOffset #24
Merged
@mpospese mpospese self-assigned this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpospese mpospese

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue-21] Expose minimumTopOffset codeandtheory/ybottomsheet-ios
1 participant
@mpospese